8000 Merge template update 2.5.1 by christopher-mohr · Pull Request #177 · nf-core/epitopeprediction · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Merge template update 2.5.1 #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 2, 2022
Merged

Merge template update 2.5.1 #177

merged 7 commits into from
Sep 2, 2022

Conversation

christopher-mohr
Copy link
Collaborator
@christopher-mohr christopher-mohr commented Sep 1, 2022 •
edited
Loading

This

  • updates to template 2.5.1
  • solve merge conflicts
  • includes Black code formatting
  • updates the Ensembl GRCh38 reference source.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
github-actions bot commented Sep 1, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e83dabd

+| ✅ 154 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

✅ Tests passed:

Run details

  • nf-core/tools version 2.5.1
  • Run at 2022-09-02 09:08:01

@christopher-mohr christopher-mohr changed the title Merge template 2 5 1 Merge template update 2.5.1 Sep 1, 2022
d4straub
d4straub approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor
@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only minor comments

christopher-mohr and others added 3 commits September 2, 2022 11:00
@christopher-mohr @d4straub
Update CHANGELOG.md
2cb74a0 
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
@christopher-mohr @d4straub
Update README.md
b823129 
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
@christopher-mohr @d4straub
Update README.md
e83dabd 
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
@christopher-mohr
Copy link
Collaborator Author

Looks good to me, only minor comments

Thank you 👍

@christopher-mohr christopher-mohr merged commit dee98be into nf-core:dev Sep 2, 2022
@christopher-mohr christopher-mohr deleted the merge-template-2-5-1 branch September 2, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol left review comments

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christopher-mohr @mirpedrol @d4straub @nf-core-bot
0