8000 Fix external tools import container by jonasscheid · Pull Request #219 · nf-core/epitopeprediction · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Fix external tools import container #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2023
Merged

Fix external tools import container #219

merged 2 commits into from
Nov 6, 2023

Conversation

jonasscheid
Copy link
Collaborator
@jonasscheid jonasscheid commented Nov 5, 2023 •
edited
Loading

This PR is a quick fix for small bug that has been introduced with the new template update. Quay.io is now the standard container registry, but for EXTERNAL_TOOLS_IMPORT biocontainers/biocontainers:v1.2.0_cv1 is used. If docker.io is specified it takes precedence.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5434e04

+| ✅ 160 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowEpitopeprediction.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-05 21:03:30

@marissaDubbelaar
Copy link
Contributor

You might want to bump to a new version and included the changes in the change log

christopher-mohr
christopher-mohr approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator
@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍

@jonasscheid jonasscheid merged commit 182fa7d into nf-core:dev Nov 6, 2023
@jonasscheid jonasscheid deleted the fix_external_container_registry branch November 6, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-mohr christopher-mohr christopher-mohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasscheid @marissaDubbelaar @christopher-mohr
0