8000 nf-test migration for ultra/align #7712 by jgmedinaf · Pull Request #8465 · nf-core/modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

nf-test migration for ultra/align #7712 #8465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

nf-test migration for ultra/align #7712 #8465

wants to merge 3 commits into from

Conversation

jgmedinaf
Copy link
@jgmedinaf jgmedinaf commented May 14, 2025 •
edited
Loading

Completed migration of module tests to nf-test.

PR checklist

Closes #7712

  • This comment contains a description of changes (wit 8000 h reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jgmedinaf jgmedinaf requested a review from maxulysse May 14, 2025 19:25
@famosab
Copy link
Contributor
famosab commented May 16, 2025

famosab
famosab requested changes May 20, 2025
View reviewed changes
Copy link
Contributor
@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the old pytest files :)

@github-project-automation github-project-automation bot moved this from Todo to In Progress in nf-test Migration May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famosab famosab famosab requested changes

@maxulysse maxulysse Awaiting requested review from maxulysse

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
nf-test
Projects
Hackathon May 2025 Boston
Status: No status
< 5277 /div>
nf-test Migration
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nf-test migration: ultra/align
2 participants
@jgmedinaf @famosab
0

Hey :) you will need to remov ethe original pytest files aswell. And adding a stub + stub tests would be nice!