Migrate universc to nf-test
#8564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
SPPearce
approved these changes
May 29, 2025
Comment on lines
+6
to
+13
| containerOptions { | ||
| ['singularity', 'apptainer'].contains(workflow.containerEngine) | ||
| ? "-B /var/tmp --writable-tmpfs" | ||
| : workflow.containerEngine == 'docker' | ||
| ? "--privileged" | ||
| : workflow.containerEngine == 'podman' | ||
| ? "--runtime crun --userns=keep-id --systemd=always" | ||
| : '' |
There was a problem hiding this comment.
I don't really like this to be honest, I think it was clearer as individual if statements.
There was a problem hiding this comment.
Also I don't think we should be having to be set all these to get it to run, but not the issue at hand here ;)
There was a problem hiding this comment.
It was to remove the big red flag with nextflow compiler
I'm not sure either that this is needed. But I can't test it 😞
SPPearce
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #7714
Closes #8478
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda