8000 make the meta.yml match the name and order of the main.nf input by cmatKhan · Pull Request #8570 · nf-core/modules · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

make the meta.yml match the name and order of the main.nf input #8570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

make the meta.yml match the name and order of the main.nf input #8570

merged 1 commit into from
May 28, 2025

Conversation

cmatKhan
Copy link
Contributor

This just corrects a typo in the meta.yml. the input val_discard_trimmed_pass was called val_discard_trimmed. I also re-ordered it to match the main.nf.

@cmatKhan cmatKhan requested review from georgiakes and Joon-Klaps and removed request for georgiakes May 28, 2025 19:45
georgiakes
georgiakes approved these changes May 28, 2025
View reviewed changes
Copy link
Member
@georgiakes georgiakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you 😊

@cmatKhan cmatKhan added this pull request to the merge queue May 28, 2025
@cmatKhan
Copy link
Contributor Author

LGTM. Thank you 😊

Thank you! wasn't sure who to ask to review

Merged via the queue into nf-core:master with commit c2f0680 May 28, 2025
10 checks passed
@cmatKhan cmatKhan deleted the meta_correct_fastq_trim_fastp_fastqc branch May 28, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgiakes georgiakes georgiakes approved these changes

@Joon-Klaps Joon-Klaps Awaiting requested review from Joon-Klaps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmatKhan @georgiakes
0