8000 Update overview figure by skrakau · Pull Request #219 · nf-core/mag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update overview figure #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2021
Merged

Update overview figure #219

merged 1 commit into from
Jul 26, 2021

Conversation

skrakau
Copy link
Member
@skrakau skrakau commented Jul 26, 2021

Added the following points to the pipeline overview figure:

  • assembly: sample- or group-wise
  • abundance estimation and visualization
  • MAG summary

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@skrakau skrakau requested a review from d4straub July 26, 2021 09:26
@github-actions
Copy link
github-actions bot commented Jul 26, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 4808089

+| ✅ 137 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.0.1
  • Run at 2021-07-26 09:28:47

d4straub
d4straub approved these changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator
@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skrakau skrakau merged commit 5aba8fb into nf-core:dev Jul 26, 2021
@skrakau skrakau deleted the update_overview_fig branch July 22, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrakau @d4straub
0