8000 Fix GTDB version in consistency by jfy133 · Pull Request #438 · nf-core/mag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix GTDB version in consistency #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2023
Merged

Fix GTDB version in consistency #438

merged 3 commits into from
May 16, 2023

Conversation

jfy133
Copy link
Member
@jfy133 jfy133 commented May 9, 2023

Conda version wasn't updated when containers were

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested review from d4straub and skrakau May 9, 2023 12:56
jfy133
jfy133 commented May 9, 2023
View reviewed changes
@github-actions
Copy link
github-actions bot commented May 9, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8e2e53b

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-09 13:17:37

JoseEspinosa
JoseEspinosa approved these changes May 16, 2023
View reviewed changes
Copy link
Member
@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jfy133 jfy133 merged commit eab1772 into dev May 16, 2023
@jfy133 jfy133 mentioned this pull request May 22, 2023
Closed
9 tasks
@alxndrdiaz alxndrdiaz mentioned this pull request May 22, 2023
Closed
@jfy133 jfy133 deleted the fix-gtdbk-version branch June 23, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@d4straub d4straub Awaiting requested review from d4straub d4straub is a code owner

@skrakau skrakau Awaiting requested review from skrakau

Assignees
No one assigned
Labels
None yet
Projects
None yet
43A2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @JoseEspinosa
0