10000 Release PR for 3.4.0 by jfy133 · Pull Request #782 · nf-core/mag · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release PR for 3.4.0 #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 84 commits into from
Apr 4, 2025
Merged

Release PR for 3.4.0 #782

merged 84 commits into from
Apr 4, 2025

Conversation

jfy133
Copy link
Member
@jfy133 jfy133 commented Apr 1, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

dialvarezs and others added 30 commits December 9, 2024 03:03
Fix checkm2 database schema checking
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Copy link
github-actions bot commented Apr 1, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a589eff

+| ✅ 334 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  52 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-04-04 07:39:56

@jfy133 jfy133 marked this pull request as ready for review April 2, 2025 11:37
Copy link
Contributor
@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some suggestions for minor doc typos

Copy link
Member
@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Michael L Heuer <heuermh@acm.org>
@jfy133
Copy link
Member Author
jfy133 commented Apr 4, 2025

Thank you @heuermh @erikrikarddaniel !

@jfy133 jfy133 merged commit 4717d3d into master Apr 4, 2025
32 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants
0