-
Notifications
You must be signed in to change notification settings - Fork 129
Release PR: 4.0.0 #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release PR: 4.0.0 #807
Conversation
Update fastqc
Add support fastp ployg trimming
@nf-core-bot fix linting |
|
|
@nf-core-bot fix linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I only had a minor question on comma addition…
Add changelog pending updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with two small comments.
docs/usage.md
Outdated
## A note on GTDB having too many files or using too many inodes | ||
|
||
The GTDB is very large both in size and by the number of files it contains. | ||
The uncompressed database requires >200k inodes, which can be problematic for users with limited storage resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is perhaps "files" better than "inodes" here? Easier to understand for the less technically savvy even if slightly less correct. Also below.
Co-authored-by: Daniel Lundin <erik.rikard.daniel@gmail.com>
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).