FEAT: Improve schema usage for input #1243
Jump to bottom
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
631e7d3 to
b1407ba
Compare
Comment on lines
-29
to
-32
| { | ||
| "type": "boolean", | ||
| "enum": ["false"] | ||
| } |
There was a problem hiding this comment.
wasn't this done so --step would work without input?
There was a problem hiding this comment.
just tried it locally with:
nextflow run . -profile test,docker --outdir results
followed by:
nextflow run . -profile test,docker --outdir results --input false --step recalibrate
and it worked without failures.
There was a problem hiding this comment.
Originally yes, but we fixed it in nf-validation, now parameters evaluating to false are not validated
mirpedrol
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mirpedrol