8000 SL-93 refactor rmarts input checks · Pull Request #10 · nf-core/rnasplice · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 SL-93 refactor rmarts input checks #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Oct 26, 2022
Merged

Conversation

ghost
Copy link
@ghost ghost commented Oct 26, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@ghost ghost merged commit af794ad into dev Oct 26, 2022
@ghost ghost deleted the SL-93-refactor-rmats-input-check branch October 26, 2022 10:30
@github-actions
Copy link

nf-core lint overall result: Failed ❌

Posted for pipeline commit 1a8d4a5

+| ✅ 156 tests passed       |+
!| ❗  16 tests had warnings |!
-| ❌  78 tests failed       |-

❌ Test failures:

  • schema_params - Param transcript_fasta from nextflow config not found in nextflow_schema.json
  • schema_params - Param additional_fasta from nextflow config not found in nextflow_schema.json
  • schema_params - Param gtf_extra_attributes from nextflow config not found in nextflow_schema.json
  • schema_params - Param gtf_group_features from nextflow config not found in nextflow_schema.json
  • schema_params - Param gencode from nextflow config not found in nextflow_schema.json
  • schema_params - Param featurecounts_group_type from nextflow config not found in nextflow_schema.json
  • schema_params - Param featurecounts_feature_type from nextflow config not found in nextflow_schema.json
  • schema_params - Param save_reference from nextflow config not found in nextflow_schema.json
  • schema_params - Param min_trimmed_reads from nextflow config not found in nextflow_schema.json
  • schema_params - Param clip_r1 from nextflow config not found in nextflow_schema.json
  • schema_params - Param clip_r2 from nextflow config not found in nextflow_schema.json
  • schema_params - Param three_prime_clip_r1 from nextflow config not found in nextflow_schema.json
  • schema_params - Param three_prime_clip_r2 from nextflow config not found in nextflow_schema.json
  • schema_params - Param trim_nextseq from nextflow config not found in nextflow_schema.json
  • schema_params - Param save_trimmed from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_trimming from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_trimgalore_fastqc from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_fastqc from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_qc from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_bigwig from nextflow config not found in nextflow_schema.json
  • schema_params - Param aligner from nextflow config not found in nextflow_schema.json
  • schema_params - Param pseudo_aligner from nextflow config not found in nextflow_schema.json
  • schema_params - Param bam_csi_index from nextflow config not found in nextflow_schema.json
  • schema_params - Param seq_center from nextflow config not found in nextflow_schema.json
  • schema_params - Param salmon_quant_libtype from nextflow config not found in nextflow_schema.json
  • schema_params - Param star_ignore_sjdbgtf from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_alignment from nextflow config not found in nextflow_schema.json
  • schema_params - Param save_unaligned from nextflow config not found in nextflow_schema.json
  • schema_params - Param save_align_intermeds from nextflow config not found in nextflow_schema.json
  • schema_params - Param save_merged_fastq from nextflow config not found in nextflow_schema.json
  • schema_params - Param rmats from nextflow config not found in nextflow_schema.json
  • schema_params - Param rmats_splice_diff_cutoff from nextflow config not found in nextflow_schema.json
  • schema_params - Param rmats_paired_stats from nextflow config not found in nextflow_schema.json
  • schema_params - Param rmats_read_len from nextflow config not found in nextflow_schema.json
  • schema_params - Param rmats_novel_splice_site from nextflow config not found in nextflow_schema.json
  • schema_params - Param rmats_min_intron_len from nextflow config not found in nextflow_schema.json
  • schema_params - Param rmats_max_exon_len from nextflow config not found in nextflow_schema.json
  • schema_params - Param dexseq_exon from nextflow config not found in nextflow_schema.json
  • schema_params - Param gff_dexseq from nextflow config not found in nextflow_schema.json
  • schema_params - Param alignment_quality from nextflow config not found in nextflow_schema.json
  • schema_params - Param aggregation from nextflow config not found in nextflow_schema.json
  • schema_params - Param deu_lfc_denominator from nextflow config not found in nextflow_schema.json
  • schema_params - Param edger_exon from nextflow config not found in nextflow_schema.json
  • schema_params - Param dexseq_dtu from nextflow config not found in nextflow_schema.json
  • schema_params - Param dtu_txi from nextflow config not found in nextflow_schema.json
  • schema_params - Param dtu_lfc_denominator from nextflow config not found in nextflow_schema.json
  • schema_params - Param min_samps_feature_expr from nextflow config not found in nextflow_schema.json
  • schema_params - Param min_samps_feature_prop from nextflow config not found in nextflow_schema.json
  • schema_params - Param min_samps_gene_expr from nextflow config not found in nextflow_schema.json
  • schema_params - Param min_feature_expr from nextflow config not found in nextflow_schema.json
  • schema_params - Param min_feature_prop from nextflow config not found in nextflow_schema.json
  • schema_params - Param min_gene_expr from nextflow config not found in nextflow_schema.json
  • schema_params - Param suppa from nextflow config not found in nextflow_schema.json
  • schema_params - Param suppa_per_local_event from nextflow config not found in nextflow_schema.json
  • schema_params - Param suppa_per_isoform from nextflow config not found in nextflow_schema.json
  • schema_params - Param local_events from nextflow config not found in nextflow_schema.json
  • schema_params - Param pool_genes from nextflow config not found in nextflow_schema.json
  • schema_params - Param suppa_tpm from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_method from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_area from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_lower_bound from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_gene_correction from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_paired from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_alpha from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_median from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_tpm_threshold from nextflow config not found in nextflow_schema.json
  • schema_params - Param diffsplice_nan_threshold from nextflow config not found in nextflow_schema.json
  • schema_params - Param clusterevents_sigthreshold from nextflow config not found in nextflow_schema.json
  • schema_params - Param clusterevents_dpsithreshold from nextflow config not found in nextflow_schema.json
  • schema_params - Param clusterevents_eps from nextflow config not found in nextflow_schema.json
  • schema_params - Param clusterevents_metric from nextflow config not found in nextflow_schema.json
  • schema_params - Param clusterevents_separation from nextflow config not found in nextflow_schema.json
  • schema_params - Param clusterevents_min_pts from nextflow config not found in nextflow_schema.json
  • schema_params - Param clusterevents_method from nextflow config not found in nextflow_schema.json
  • schema_params - Param gtf from nextflow config not found in nextflow_schema.json
  • schema_params - Param gff from nextflow config not found in nextflow_schema.json
  • schema_params - Param star_index from nextflow config not found in nextflow_schema.json
  • schema_params - Param salmon_index from nextflow config not found in nextflow_schema.json

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
  • pipeline_todos - TODO string in README.md: Write a 1-2 sentence summary of what data the pipeline is for and what it does
  • pipeline_todos - TODO string in README.md: Add full-sized test dataset and amend the paragraph below if applicable
  • pipeline_todos - TODO string in README.md: Fill in short bullet-pointed list of the default steps in the pipeline
  • pipeline_todos - TODO string in README.md: Update the example "typical command" below used to run the pipeline
  • pipeline_todos - TODO string in README.md: If applicable, make list of people who have also contributed
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in rnasplice.nf: Add all file path parameters for the pipeline to the list below
  • pipeline_todos - TODO string in output.md: Write this documentation describing your workflow's output
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-10-26 10:31:36

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0