Fix module tests #42

jma1991 · 2023-02-23T14:18:08Z

PR checklist

This comment contains a description of changes (with reason).
If you've fixed a bug or added code that should be tested, add tests!
If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
Make sure your code lints (nf-core lint).
Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
Usage Documentation in docs/usage.md is updated.
Output Documentation in docs/output.md is updated.
CHANGELOG.md is updated.
README.md is updated (including new tool citations and authors/contributors).

github-actions · 2023-02-23T14:20:18Z

`nf-core lint` overall result: Passed ✅ ⚠️

Posted for pipeline commit 61a05a1

+| ✅ 157 tests passed       |+
!| ❗  63 tests had warnings |!

❗ Test warnings:

pipeline_todos - TODO string in README.md: Add full-sized test dataset and amend the paragraph below if applicable
pipeline_todos - TODO string in README.md: Update the example "typical command" below used to run the pipeline
pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
schema_description - No description provided in schema for parameter: gff
schema_description - No description provided in schema for parameter: rmats
schema_description - No description provided in schema for parameter: rmats_splice_diff_cutoff
schema_description - No description provided in schema for parameter: rmats_paired_stats
schema_description - No description provided in schema for parameter: rmats_read_len
schema_description - No description provided in schema for parameter: rmats_novel_splice_site
schema_description - No description provided in schema for parameter: rmats_min_intron_len
schema_description - No description provided in schema for parameter: rmats_max_exon_len
schema_description - No description provided in schema for parameter: dexseq_exon
schema_description - No description provided in schema for parameter: save_dexseq_annotation
schema_description - No description provided in schema for parameter: gff_dexseq
schema_description - No description provided in schema for parameter: alignment_quality
schema_description - No description provided in schema for parameter: aggregation
schema_description - No description provided in schema for parameter: deu_lfc_denominator
schema_description - No description provided in schema for parameter: edger_exon
schema_description - No description provided in schema for parameter: dexseq_dtu
schema_description - No description provided in schema for parameter: dtu_txi
schema_description - No description provided in schema for parameter: dtu_lfc_denominator
schema_description - No description provided in schema for parameter: min_samps_feature_expr
schema_description - No description provided in schema for parameter: min_samps_feature_prop
schema_description - No description provided in schema for parameter: min_samps_gene_expr
schema_description - No description provided in schema for parameter: min_feature_expr
schema_description - No description provided in schema for parameter: min_feature_prop
schema_description - No description provided in schema for parameter: min_gene_expr
schema_description - No description provided in schema for parameter: suppa
schema_description - No description provided in schema for parameter: suppa_per_local_event
schema_description - No description provided in schema for parameter: suppa_per_isoform
schema_description - No description provided in schema for parameter: suppa_tpm
schema_description - No description provided in schema for parameter: generateevents_pool_genes
schema_description - No description provided in schema for parameter: generateevents_localevents
schema_description - No description provided in schema for parameter: generateevents_boundary
schema_description - No description provided in schema for parameter: generateevents_threshold
schema_description - No description provided in schema for parameter: generateevents_exon_length
schema_description - No description provided in schema for parameter: psiperevent_total_filter
schema_description - No description provided in schema for parameter: diffsplice_local_event
schema_description - No description provided in schema for parameter: diffsplice_isoform
schema_description - No description provided in schema for parameter: diffsplice_method
schema_description - No description provided in schema for parameter: diffsplice_area
schema_description - No description provided in schema for parameter: diffsplice_lower_bound
schema_description - No description provided in schema for parameter: diffsplice_gene_correction
schema_description - No description provided in schema for parameter: diffsplice_paired
schema_description - No description provided in schema for parameter: diffsplice_alpha
schema_description - No description provided in schema for parameter: diffsplice_median
schema_description - No description provided in schema for parameter: diffsplice_tpm_threshold
schema_description - No description provided in schema for parameter: diffsplice_nan_threshold
schema_description - No description provided in schema for parameter: clusterevents_local_event
schema_description - No description provided in schema for parameter: clusterevents_isoform
schema_description - No description provided in schema for parameter: clusterevents_sigthreshold
schema_description - No description provided in schema for parameter: clusterevents_dpsithreshold
schema_description - No description provided in schema for parameter: clusterevents_eps
schema_description - No description provided in schema for parameter: clusterevents_metric
< 8000 a href="https://nf-co.re/tools-docs/lint_tests/schema_description.html" rel="nofollow">schema_description - No description provided in schema for parameter: clusterevents_separation
schema_description - No description provided in schema for parameter: clusterevents_min_pts
schema_description - No description provided in schema for parameter: clusterevents_method

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .editorconfig
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/CONTRIBUTING.md
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/config.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/ci.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: assets/nf-core-rnasplice_logo_light.png
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: conf/test_full.config
files_exist - File found: docs/images/nf-core-rnasplice_logo_light.png
files_exist - File found: docs/images/nf-core-rnasplice_logo_dark.png
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: lib/nfcore_external_java_deps.jar
files_exist - File found: lib/NfcoreSchema.groovy
files_exist - File found: lib/NfcoreTemplate.groovy
files_exist - File found: lib/Utils.groovy
files_exist - File found: lib/WorkflowMain.groovy
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: conf/igenomes.config
files_exist - File found: .github/workflows/awstest.yml
files_exist - File found: .github/workflows/awsfulltest.yml
files_exist - File found: lib/WorkflowRnasplice.groovy
files_exist - File found: modules.json
files_exist - File found: pyproject.toml
files_exist - File not found check: Singularity
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: bin/markdown_to_html.r
files_exist - File not found check: conf/aws.config
files_exist - File not found check: .github/workflows/push_dockerhub.yml
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: docs/images/nf-core-rnasplice_logo.png
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: lib/Checks.groovy
files_exist - File not found check: lib/Completion.groovy
files_exist - File not found check: lib/Workflow.groovy
files_exist - File not found check: .travis.yml
nextflow_config - Config variable found: manifest.name
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: manifest.homePage
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: params.input
nextflow_config - Config variable found: params.show_hidden_params
nextflow_config - Config variable found: params.schema_ignore_params
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config variable (correctly) not found: params.enable_conda
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config manifest.name began with nf-core/
nextflow_config - Config variable manifest.homePage began with https://github.com/nf-core/
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config manifest.version ends in dev: '1.0dev'
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - CODE_OF_CONDUCT.md matches the template
files_unchanged - LICENSE matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/CONTRIBUTING.md matches the template
files_unchanged - .github/ISSUE_TEMPLATE/bug_report.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/config.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
files_unchanged - .github/PULL_REQUEST_TEMPLATE.md matches the template
files_unchanged - .github/workflows/branch.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - .github/workflows/linting.yml matches the template
files_unchanged - assets/email_template.html matches the template
files_unchanged - assets/email_template.txt matches the template
files_unchanged - assets/sendmail_template.txt matches the template
files_unchanged - assets/nf-core-rnasplice_logo_light.png matches the template
files_unchanged - docs/images/nf-core-rnasplice_logo_light.png matches the template
files_unchanged - docs/images/nf-core-rnasplice_logo_dark.png matches the template
files_unchanged - docs/README.md matches the template
files_unchanged - lib/nfcore_external_java_deps.jar matches the template
files_unchanged - lib/NfcoreSchema.groovy matches the template
files_unchanged - lib/NfcoreTemplate.groovy matches the template
files_unchanged - .gitignore matches the template
files_unchanged - .prettierignore matches the template
files_unchanged - pyproject.toml matches the template
actions_ci - '.github/workflows/ci.yml' is triggered on expected events
actions_ci - '.github/workflows/ci.yml' checks minimum NF version
actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml does not use -profile test
readme - README Nextflow minimum version badge matched config. Badge: 22.10.1, Config: 22.10.1
readme - README Nextflow minimum version in Quick Start section matched config. README: 22.10.1, Config: 22.10.1
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (168 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_lint - Input mimetype lint passed: 'text/csv'
schema_params - Schema matched params returned from nextflow config
actions_schema_validation - Workflow validation passed: ci.yml
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: awsfulltest.yml
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: fix-linting.yml
actions_schema_validation - Workflow validation passed: awstest.yml
actions_schema_validation - Workflow validation passed: linting.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - 'assets/multiqc_config.yml' follows the ordering scheme of the minimally required plugins.
multiqc_config - 'assets/multiqc_config.yml' contains a matching 'report_comment'.
multiqc_config - 'assets/multiqc_config.yml' contains 'export_plots: true'.
modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'

Run details

nf-core/tools version 2.7.2
Run at 2023-02-23 14:19:44

github-actions · 2023-03-03T12:31:01Z

Python linting (`black`) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

Install black: pip install black
Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

jma1991 added 4 commits February 22, 2023 13:58

modules update

6342bdf

various fixes to solve module test problems

6904208

black linter

d1d20c1

test subworkflows

61a05a1

jma1991 requested a review from bensouthgate March 3, 2023 12:12

bensouthgate approved these changes Mar 3, 2023

View reviewed changes

bensouthgate merged commit f8f78e2 into nf-core:dev Mar 3, 2023

jma1991 deleted the fix_module_tests branch March 4, 2023 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix module tests #42

Fix module tests #42

Uh oh!

Uh oh!

❗ Test warnings:

✅ Tests passed:

Run details

Uh oh!

Uh oh!

Uh oh!

Fix module tests #42

Fix module tests #42

Uh oh!

Conversation

PR checklist

Uh oh!

Uh oh!

nf-core lint overall result: Passed ✅ ⚠️

❗ Test warnings:

✅ Tests passed:

Run details

Uh oh!

Python linting (black) is failing

Uh oh!

Uh oh!

`nf-core lint` overall result: Passed ✅ ⚠️

Python linting (`black`) is failing