8000 Merging template updates by jma1991 · Pull Request #54 · nf-core/rnasplice · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merging template updates #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2023
Merged

Merging template updates #54

merged 4 commits into from
May 19, 2023

Conversation

jma1991
Copy link
Collaborator
@jma1991 jma1991 commented May 19, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/rnasplice branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
github-actions bot commented May 19, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ce71c80

+| ✅ 157 tests passed       |+
!| ❗  22 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 23]
  • system_exit - System.exit in WorkflowRnasplice.groovy: // System.exit(1) [line 48]
  • system_exit - System.exit in WorkflowRnasplice.groovy: // System.exit(1) [line 53]
  • system_exit - System.exit in WorkflowRnasplice.groovy: // System.exit(1) [line 59]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 66]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 71]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 79]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 83]
  • system_exit - System.exit in WorkflowRnasplice.groovy: // System.exit(1) [line 110]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 119]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 124]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 180]
  • system_exit - System.exit in WorkflowRnasplice.groovy: // System.exit(1) [line 390]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 422]
  • system_exit - System.exit in WorkflowRnasplice.groovy: System.exit(1) [line 438]

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-19 14:03:57

@jma1991 jma1991 merged commit a94658b into nf-core:dev May 19, 2023
@jma1991 jma1991 deleted the merging-template-updates branch May 23, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensouthgate bensouthgate Awaiting requested review from bensouthgate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jma1991 @nf-core-bot
0