-
Notifications
You must be signed in to change notification settings - Fork 1
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: nfejzic/mathemascii
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: nfejzic/mathemascii
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 25 files changed
- 2 contributors
Commits on Dec 27, 2023
-
feat!: improve rendering with fallbacks during parsing (#14)
In this PR we introduce fallback during parsing. This makes it more consistent with the https://asciimath.org/ parser. Whenever a symbol is encountered, that can't be part of an expression (like unary, binary or grouping expressions), we parse this symbol as either `Var::UnknownOperator` for symbols that weren't recognized by the lexer, or as `Var::Other` for symbols that were recognized but aren't part of any expression. These are rendered as operators (`<mo>`). Also, parser now closes grouping expressions implicitly with a close ignored grouping token. The unary and binary expression also get an empty operator as a default expression instead of not parsing until end. This makes it possible to get a visual feedback when live rendering during typing of expressions. For example, previously `sqrt(` would not render anything, but `sqrt(x)` would render $\sqrt{x}$. By introducing the changes above, the `sqrt(` now renders to $\sqrt{}$. Changelog: fix: simplify ungroup_map by direct conversion fix: use more operator constructors fix: correctly handle `norm` groupings chore: update alemat to latest version fix: handle dots as operators instead of idents fix: use more pre-defined operator constructors fix: correctly lex set minus operators fix: improve handling of cdots etc fix: simplify handling of groupings fix: improve handling of matrix groupings chore: reformat for better readability fix: correctly parse `cdots`, `ldots` etc feat: implicitly close grouping expressions feat!: remove `Token::is_var` method feat: fallback to operator when no expr recognized test: update snapshots fix: fallback to operator when lexing unknown symbol fix: add fallback to Element conversion for Other keyword fix: add fallbacks when parsing color binary expr fix: fallback to default expression when parsing unary fix: correctly render `and` and `or` logicals fix: render groupings in a `mrow` element fix: correctly lex the divide symbol `-:`
Configuration menu - View commit details
-
Copy full SHA for 7d8c86a - Browse repository at this point
Copy the full SHA 7d8c86aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e9e42f - Browse repository at this point
Copy the full SHA 9e9e42fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3c9b5e - Browse repository at this point
Copy the full SHA d3c9b5eView commit details -
chore: remove release-please manifest.
Release please seems to ignore settings in manifest file, so remove it... Release-As: 0.4.0
Configuration menu - View commit details
-
Copy full SHA for 95cdecd - Browse repository at this point
Copy the full SHA 95cdecdView commit details -
chore(main): release 0.4.0 (#16)
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.1...v0.4.0) (2023-12-27) ### ⚠ BREAKING CHANGES * remove `Token::is_var` method * improve rendering with fallbacks during parsing ([#14](#14)) ### Features * fallback to operator when no expr recognized ([7d8c86a](7d8c86a)) * implicitly close grouping expressions ([7d8c86a](7d8c86a)) * improve rendering with fallbacks during parsing ([#14](#14)) ([7d8c86a](7d8c86a)) * remove `Token::is_var` method ([7d8c86a](7d8c86a)) ### Bug Fixes * add fallback to Element conversion for Other keyword ([7d8c86a](7d8c86a)) * add fallbacks when parsing color binary expr ([7d8c86a](7d8c86a)) * correctly handle `norm` groupings ([7d8c86a](7d8c86a)) * correctly lex set minus operators ([7d8c86a](7d8c86a)) * correctly lex the divide symbol `-:` ([7d8c86a](7d8c86a)) * correctly parse `cdots`, `ldots` etc ([7d8c86a](7d8c86a)) * correctly render `and` and `or` logicals ([7d8c86a](7d8c86a)) * fallback to default expression when parsing unary ([7d8c86a](7d8c86a)) * fallback to operator when lexing unknown symbol ([7d8c86a](7d8c86a)) * handle dots as operators instead of idents ([7d8c86a](7d8c86a)) * improve handling of cdots etc ([7d8c86a](7d8c86a)) * improve handling of matrix groupings ([7d8c86a](7d8c86a)) * render groupings in a `mrow` element ([7d8c86a](7d8c86a)) * simplify handling of groupings ([7d8c86a](7d8c86a)) * simplify ungroup_map by direct conversion ([7d8c86a](7d8c86a)) * use more operator constructors ([7d8c86a](7d8c86a)) * use more pre-defined operator constructors ([7d8c86a](7d8c86a)) ### Miscellaneous Chores * remove release-please manifest. ([95cdecd](95cdecd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 42cc9d8 - Browse repository at this point
Copy the full SHA 42cc9d8View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.3.1...v0.4.0