8000 Treat empty string as valid translations (at least conditionally) · Issue #231 · ngx-translate/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Treat empty string as valid translations (at least conditionally) #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DethAriel opened this issue Sep 8, 2016 · 2 comments · Fixed by #261
Closed

Treat empty string as valid translations (at least conditionally) #231

DethAriel opened this issue Sep 8, 2016 · 2 comments · Fixed by #261

Comments

@DethAriel
Copy link
Contributor

I'm submitting a ...

[x] bug report

Current behavior
If translation yields empty string, the translation is considered missing.

Expected/desired behavior
Empty strings, should either be considered valid translations always, or with a conditional switch, like

translateService.tolerateEmptyStrings();

Reproduction of the problem
See this plunker

What is the motivation / use case for changing the behavior?
Use case is pretty much described in #223 . When localizing links, this is essential.

** Comments **
One could add a space there:

{
  "SOME_KEY": " "
}

but this is error-prone as such kinda redundant whitespace can be lost when localization team does its job.

Please tell us about your environment:

  • ng2-translate version: 2.4.3
  • Angular version: 2.0.0-rc.6
  • Browser: all
  • Language: all
@ocombe
Copy link
Member
ocombe commented Sep 8, 2016

You're right, empty string shouldn't be an error ! Sorry about that, I think it's a regression

SamVerschueren added a commit to SamVerschueren/ng2-translate that referenced this issue Oct 4, 2016
@SamVerschueren
fix(translate): treat empty string as valid translation - fixes ngx-t…
0f9d7f5 
…ranslate#231
@SamVerschueren SamVerschueren mentioned this issue Oct 4, 2016
Merged
ocombe added a commit that referenced this issue Oct 4, 2016
@ocombe
fix(translate): treat empty string as valid translation
850ea51 
Fixes #231
@ngehlert
Copy link
ngehlert commented Apr 4, 2017 •
edited
Loading

would you be willing to accept a PR that adds the suggested conditional switch?
I'd rather have empty values displayed with something like "[MISSING]: KEY" then just empty strings. At least this is the way I'm used to it with the old angular-gettext
@ocombe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(translate): treat empty string as valid translation - fixes #231 SamVerschueren/ng2-translate
3 participants
@ocombe @DethAriel @ngehlert
0