10000 docs: example code not compiling by benoitnesme · Pull Request #2059 · ngxs/store · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: example code not compiling #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

docs: example code not compiling #2059

merged 1 commit into from
Sep 26, 2023

Conversation

benoitnesme
Copy link
Contributor
@benoitnesme benoitnesme commented Sep 21, 2023 •
edited
Loading

doc: fix one Selector code sample that is not compiling

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The provided code sample didn't compile and was misleading, especially because of the lack of [] around AnimalsState in @selector

Issue Number: N/A

What is the new behavior?

The code sample will compile directly when copied to local machine

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@benoitnesme
Fix example code not compiling
cce2335 
The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector
@markwhitfeld markwhitfeld changed the title Fix example code not compiling docs: example code not compiling Sep 26, 2023
@markwhitfeld markwhitfeld merged commit a8fcbd0 into ngxs:release Sep 26, 2023
markwhitfeld pushed a commit that referenced this pull request Nov 10, 2023
@OanaSurdea @benoitnesme
docs(installation): add snippets for devtools-plugin (#2077)
d2f9ef4 
* docs: example code not compiling (#2059)

The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector

* Update installation.md

Added snippet for installing the devtools plugin.

---------

Co-authored-by: benoitnesme <38083927+benoitnesme@users.noreply.github.com>
markwhitfeld pushed a commit that referenced this pull request Nov 30, 2023
@OanaSurdea @benoitnesme @markwhitfeld
docs(installation): add snippets for devtools-plugin (#2077)
0b737ff 
* docs: example code not compiling (#2059)

The provide example doesn't compile and is misleading, especially because of the lack of [] around AnimalsState in @selector

* Update installation.md

Added snippet for installing the devtools plugin.

---------

Co-authored-by: benoitnesme <38083927+benoitnesme@users.noreply.github.com>
(cherry picked from commit d2f9ef4)
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@arturovt arturovt Awaiting requested review from arturovt arturovt is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
v.18.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitnesme @markwhitfeld
0