8000 Revert "fix(store): `ctx.getState` should return `DeepReadOnly<>`" by arturovt · Pull Request #2113 · ngxs/store · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "fix(store): ctx.getState should return DeepReadOnly<>" #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2024
Merged

Revert "fix(store): ctx.getState should return DeepReadOnly<>" #2113

merged 1 commit into from
Mar 16, 2024

Conversation

arturovt
Copy link
Member

Reverts #2110

@nx-cloud Nx Cloud
Copy link
nx-cloud bot commented Mar 16, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b830e83. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@bundlemon BundleMon
Copy link
bundlemon bot commented Mar 16, 2024

BundleMon (Integration Projects)

Unchanged files (2)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
 68.48KB +1%
✅ Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
 66.98KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt marked this pull request as ready for review March 16, 2024 13:46
@arturovt arturovt merged commit 6ff0d85 into master Mar 16, 2024
@arturovt arturovt deleted the revert-2110-fix/deep-readonly branch March 16, 2024 13:46
@markwhitfeld
Copy link
Member

@arturovt what is the reason for the revert?

@arturovt
Copy link
Member Author

DMed in google chat

@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
v.18.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arturovt @markwhitfeld
0