refactor:update tui-code-snippet@2.2.0 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- set webpack optimization
- apply toast-ui.release-notes
- apply tui-code-snippet@2.2.0
- refactor examples
jung-han
reviewed
Jan 3, 2020
jung-han
reviewed
Jan 3, 2020
jung-han
reviewed
Jan 3, 2020
Comment on lines
+40
to
+48
| var result = document.getElementById('result'); | ||
|
|
||
| var colorpicker = tui.colorPicker.create({ | ||
| container: document.getElementById('color-picker') | ||
| }); | ||
|
|
||
| colorpicker.on('selectColor', function(obj) { | ||
| console.log(obj); | ||
| colorpicker.on('selectColor', function(ev) { | ||
| result.value = JSON.stringify(ev, null, 8); | ||
| console.log(ev); |
There was a problem hiding this comment.
README는 ES6로 작성이 된 것 같은데, 그럼 예제코드도 같이 수정이 되어야 하지 않을까요?_?
jung-han
reviewed
Jan 3, 2020
jung-han
reviewed
Jan 3, 2020
jung-han
reviewed
Jan 3, 2020
jung-han
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
docs/getting-started.md
Outdated
Comment on lines
15
to
18
| import ColorPicker from 'tui-color-picker'; | ||
| import 'tui-color-picker/dist/tui-color-picker.css'; | ||
|
|
||
| const colorpicker = ColorPicker.create({ |
There was a problem hiding this comment.
여기도 생성자 함수처럼 가져오고 있는데 변경해야겠습니다. 아니면 이렇게 인스턴스 생성하는 팩토리 함수만 가져오는 방식으로 가이드하는건 어떨까요?
import {create} from 'tui-color-picker';
const instance = create({ ... });There was a problem hiding this comment.
create만 있다면 어떤 인스턴스를 만드는지 명확하게 드러나지 않아서 코드 가독성이 떨어지지 않을까요? 기존 방식인 colorPicker.create가 더 낫다고 생각합니다!
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
| @@ -31,7 +31,7 @@ | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "@babel/core": "^7.5.5", | |||
| "@toast-ui/release-notes": "^2.0.0", | |||
| "@toast-ui/release-notes": "^2.0.1", | |||
| "babel-eslint": "^7.1.0", | |||
| "babel-loader": "^8.0.6", | |||
There was a problem hiding this comment.
바벨을 사용하나요? 그렇다면 es6 코드를 사용해도 되겠네요.
일단 코드 변경하는건 작업량이 많으니 추후에 진행할 수 있도록 이슈 등록 부탁드릴게요~
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
reviewed
Jan 3, 2020
seonim-ryu
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.