Fix macros for reserved prefixes on lifetimes #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust RFC 3101 reserved, in Rust 2021, prefixed identifiers such as `prefix#ident`. This should have been applied to lifetimes before the release of the edition, but was not. The Rust Project is planning to fix this, and this commit prepares this crate for that. The key change is as follows. There are many places where this crate says, in the context of `quote!(..)`: ```rust impl<'prov, #(#generic_params),*> ``` But there were two places where this was spelled: ```rust impl<'prov#(,#generic_params)*> ``` It's these that will break, and so this commit changes these to be consistent with the first spelling. An alternate way to fix this would be to just add a space, such as: ```rust impl<'prov #(,#generic_params)*> ``` ...but the first fix seems more idiomatic. The other changes here aren't strictly necessary, but they make things more consistent and rely on fewer peculiarities of the Rust parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust RFC 3101 reserved, in Rust 2021, prefixed identifiers such as
prefix#ident. This should have been applied to lifetimes before the release of the edition, but was not. The Rust Project is planning to fix this, and this commit prepares this crate for that.The key change is as follows. There are many places where this crate says, in the context of
quote!(..):But there were two places where this was spelled:
It's these that will break, and so this commit changes these to be consistent with the first spelling. An alternate way to fix this would be to just add a space, such as:
...but the first fix seems more idiomatic.
The other changes here aren't strictly necessary, but they make things more consistent and rely on fewer peculiarities of the Rust parser.
After merging this, you'll probably want to make a new release of this crate for the benefit of any dependent crates.
This crate was identified via a crater run on this PR:
'r#ident) rust-lang/rust#126452