fix: pydantic warnings #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyager
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #115
We observed the same warnings as in #115 and tracked it down to the case where we had 3 dbt Projects where:
A -> B (Project B references models from A)
A -> C (Project C references models from A)
B -> C (Project C references models from B)
I was looking at the
type(self.resource_type)atdbt-loom/dbt_loom/manifests.py
Line 88 in 2293034
and saw that most nodes had "<enum 'NodeType'>", except for seeds and hooks from Project A which are loaded via Project B (here the type is "<class 'str'>"). The same seeds/hooks from Project A directly have "<enum 'NodeType'>" (in our constellation these resources are loaded twice as we reference both A and B with dbt-loom)
cf. https://stackoverflow.com/questions/65209934/pydantic-enum-field-does-not-get-converted-to-string