8000 [#432] [Bug] Fix: DeliverableConstants.rb does not exist by ducbm051291 · Pull Request #440 · nimblehq/ios-templates · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#432] [Bug] Fix: DeliverableConstants.rb does not exist #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

[#432] [Bug] Fix: DeliverableConstants.rb does not exist #440

merged 1 commit into from
Feb 10, 2023

Conversation

ducbm051291
Copy link
Contributor

What happened

  • Because the iOS template uses Fastlane Swift, the DeliverableConstants.rb was replaced with Constant.swift. We need to update deliverable_setup.sh to open Constants.swift instead of DeliverableConstants.rb

Insight

  • Update deliverable_setup.sh files: Change from opening DeliverableConstants.rb file to Constant.swift file

Proof Of Work

demo.mov

@ducbm051291
[#432] - Update deliverable_setup.sh files: Change from opening Deliv…
674b489 
…erableConstants.rb file to Constant.swift file
@ducbm051291 ducbm051291 added this to the 4.2.0 milestone Feb 8, 2023
@ducbm051291 ducbm051291 self-assigned this Feb 8, 2023
@ducbm051291 ducbm051291 linked an issue Feb 8, 2023 that may be closed by this pull request
Fix: DeliverableConstants.rb does not exist #432
Closed
suho
8000 suho approved these changes Feb 9, 2023
View reviewed changes
@vnntsu vnntsu merged commit d611caa into develop Feb 10, 2023
@vnntsu vnntsu deleted the bug/#432-deliverable-constants-does-not-exist branch February 10, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarss edgarss edgarss approved these changes

@Shayokh144 Shayokh144 Shayokh144 approved these changes

@vnntsu vnntsu vnntsu approved these changes

@markgravity markgravity markgravity approved these changes

@suho suho suho approved these changes

@blyscuit blyscuit Awaiting requested review from blyscuit blyscuit is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@Thieurom Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

@nkhanh44 nkhanh44 Awaiting requested review from nkhanh44 nkhanh44 is a code owner

Assignees

@ducbm051291 ducbm051291

Labels
type : bug
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Fix: DeliverableConstants.rb does not exist
6 participants
@ducbm051291 @edgarss @Shayokh144 @vnntsu @markgravity @suho
0