8000 [#510] GitHub actions can remove custom keychain when needed by ducbm051291 · Pull Request #513 · nimblehq/ios-templates · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#510] GitHub actions can remove custom keychain when needed #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 30, 2023
Merged

[#510] GitHub actions can remove custom keychain when needed #513

merged 6 commits into from
Aug 30, 2023

Conversation

ducbm051291
Copy link
Contributor
@ducbm051291 ducbm051291 commented Aug 22, 2023 •
edited
Loading

What happened 👀

  • Add a new step: Remove Keychain in GitHub action workflows to remove the keychain after completing the job so in case the self-hosted runner, the system shall not show a dialog popup to ask for a keychain and freeze the job

  • Modify variable keychainName in Constants.swift to allow automatic generation from make.sh with {project_name}.

Insight 📝

  • N/A

Proof Of Work 📹

Remove keychain step result

CleanShot 2023-08-22 at 14 00 28@2x

Modify variable keychainName in Constants.swift result

CleanShot 2023-08-24 at 09 52 21

CleanShot 2023-08-24 at 09 55 40

vnntsu and others added 3 commits August 22, 2023 09:57
@vnntsu @ducbm051291
Revert "[Chore] [#423] Update a specific name for deploying staging b…
c474f72 
…uild to firebase workflow"
@nkhanh44 @ducbm051291
[#423] Update names for workflows and their descriptions
123118f
@ducbm051291
[#510] Add function remove in Keychain to remove keychain in case the…
fa4a681 
… runner is self-hosted

Add new fastlane lane removeKeychain
Add remove keychain step in github action workflow
Add continue-on-error: true for step remove keychain
@ducbm051291 ducbm051291 self-assigned this Aug 22, 2023
@ducbm051291 ducbm051291 marked this pull request as ready for review August 22, 2023 07:59
blyscuit
blyscuit reviewed Aug 23, 2023
View reviewed changes
Copy link
Collaborator
@blyscuit blyscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the keychain name auto populate.

Modify variable keychainName in Constants.swift to allow automatic generation from make.sh with {project_name}.

markgravity
markgravity reviewed Aug 23, 2023
View reviewed changes
@ducbm051291 ducbm051291 force-pushed the feature/510-github-actions-can-remove-custom-keychain-when-needed branch from 337aaf8 to 71ef49a Compare August 24, 2023 02:46
@ducbm051291
[#510] Update keychainName default value with "{PROJECT_NAME}" to be …
c37549f 
…replaced when run make.sh

Update make.sh to accept minimum-version
blyscuit
blyscuit reviewed Aug 24, 2023
View reviewed changes
Thieurom
Thieurom reviewed Aug 25, 2023
View reviewed changes
blyscuit
blyscuit approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator
@blyscuit blyscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@blyscuit blyscuit added this pull request to the merge queue Aug 30, 2023
Merged via the queue into develop with commit 81d9e23 Aug 30, 2023
@blyscuit blyscuit deleted the feature/510-github-actions-can-remove-custom-keychain-when-needed branch August 30, 2023 08:04
@blyscuit blyscuit added this to the 4.8.0 milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyscuit blyscuit blyscuit approved these changes

@markgravity markgravity markgravity approved these changes

@Thieurom Thieurom Thieurom approved these changes

@suho suho suho approved these changes

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@nkhanh44 nkhanh44 Awaiting requested review from nkhanh44 nkhanh44 is a code owner

Assignees

@ducbm051291 ducbm051291

Labels
type : feature
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ducbm051291 @blyscuit @markgravity @Thieurom @suho @vnntsu @nkhanh44
0