8000 FIX: Move telemetry atexit into entrypoint func by mgxd · Pull Request #1067 · nipreps/mriqc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIX: Move telemetry atexit into entrypoint func #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

FIX: Move telemetry atexit into entrypoint func #1067

merged 2 commits into from
Feb 28, 2023

Conversation

mgxd
Copy link
Contributor
@mgxd mgxd commented Feb 27, 2023

The final process status is not properly sent to migas, as the exit function is not registered correctly.

This mirrors the logic used in fmriprep.

mgxd added 2 commits February 27, 2023 12:27
@mgxd
FIX: Move telemetry atexit into entrypoint func
200b5d8 
The final process status is not properly sent to migas, as the exit function is not registered in the correct location.
@mgxd
STY: Flake8
3e3f017
@oesteban
Copy link
Member

Should we move the state tracking to the config file?

oesteban
oesteban approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member
@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive global state tracking should be done through the config singleton. Let's merge this in so that both fMRIPrep and MRIQC work similarly and then please consider that idea for future maintenance.

@mgxd mgxd merged commit a08c8a0 into nipreps:master Feb 28, 2023
@mgxd mgxd deleted the fix/migas-exitstatus branch February 28, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgxd @oesteban
0