8000 FIX: Underspecified regex sets BIDSLayout to ignore data with sesions by oesteban · Pull Request #1094 · nipreps/mriqc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIX: Underspecified regex sets BIDSLayout to ignore data with sesions #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 24, 2023
Merged

FIX: Underspecified regex sets BIDSLayout to ignore data with sesions #1094

merged 6 commits into from
Mar 24, 2023

Conversation

oesteban
Copy link
Member

This PR removes one ignore pattern that resulted in ignoring all data when sessions are defined.

To preempt regressions, a simple test is added, using data structures from @dmd (see #921 (comment)).

I will be adding more test structures from #921 and other reported problems.

Resolves #1086.

oesteban added 5 commits March 23, 2023 23:19
@oesteban
fix: add testing data to avoid regressions
68da3b4
@oesteban
fix: underspecified regex sets BIDSLayout to ignore data with ses…
e2ed100 
…sions

This PR removes one ignore pattern that resulted in ignoring all data when sessions are defined.

To preempt regressions, a simple test is added, using data from @dmd (see [#921 (comment)](#921 (comment))).

I will be adding more test structures from #921 and other reported problems.

Resolves #1086.
@oesteban
enh: more programmatic testing
2a96710
@oesteban
fix: final improvements
18548a3
@oesteban
sty: run black on new test files
6690ced
effigies
effigies reviewed Mar 24, 2023
View reviewed changes
@oesteban @effigies
enh: add code suggestion by @effigies
9ee9f9a 9EE6 
Also modify one of the tests including some dwis to check they are indeed filtered out.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@oesteban
Copy link
Member Author

The new tests are passing on circle:

mriqc/tests/test_config.py::test_bids_indexing_manifest[gh921-dmd-20220428-0] PASSED
mriqc/tests/test_config.py::test_bids_indexing_manifest[gh921-dmd-20230319-0] PASSED
mriqc/tests/test_config.py::test_bids_indexing_manifest[gh1086-ds004134] PASSED

@oesteban oesteban merged commit 02bcf89 into master Mar 24, 2023
@oesteban oesteban deleted the fix/1086-bids-ignore-with-sessions branch March 24, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 23.0.0 - can't find subjects in BIDS folder
2 participants
@oesteban @effigies
0