8000 MAINT: Update deprecated ``nibabel.spatialimage.get_data()`` calls by oesteban · Pull Request #1096 · nipreps/mriqc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MAINT: Update deprecated nibabel.spatialimage.get_data() calls #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2023
Merged

MAINT: Update deprecated nibabel.spatialimage.get_data() calls #1096

merged 2 commits into from
Mar 27, 2023

Conversation

oesteban
Copy link
Member

No description provided.

@oesteban oesteban requested a review from effigies March 26, 2023 20:54
effigies
effigies reviewed Mar 27, 2023
View reviewed changes
Copy link
Member
@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various suggestions, some may be out of scope for this PR. Mostly suggestions intended to reduce potential (or certain) array copies. One actual bug in your diff (missing .dataobj).

@oesteban oesteban force-pushed the fix/stop-nibabel-get_data branch from 609bbdc to 6cecdfb Compare March 27, 2023 06:23
@oesteban
Copy link
Member Author

Thanks much for your time! I learned a lot :)

@oesteban @effigies
Apply suggestions from code review
4028f45 
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
@oesteban oesteban force-pushed the fix/stop-nibabel-get_data branch from 6cecdfb to 4028f45 Compare March 27, 2023 06:25
@oesteban oesteban merged commit 4a03ca1 into master Mar 27, 2023
@oesteban oesteban deleted the fix/stop-nibabel-get_data branch March 27, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oesteban @effigies
0