-
Notifications
You must be signed in to change notification settings - Fork 28
rf: Allow callers to pass a pre-computed epi2anat transform for SyN #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
- Coverage 84.32% 2.55% -81.78%
==========================================
Files 30 30
Lines 2846 2854 +8
Branches 367 294 -73
==========================================
- Hits 2400 73 -2327
- Misses 376 2780 +2404
+ Partials 70 1 -69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dockerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to push these updates independently of the rest of the PR?
else: | ||
workflow.connect([ | ||
(inputnode, transform_list, [("epi2anat_xfm", "in1")]), | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
]) | |
]) # fmt:skip |
@@ -44,12 +46,11 @@ | |||
@pytest.mark.parametrize( | |||
("n_bold", "coregister", "sd_prior"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
("n_bold", "coregister", "sd_prior"), | |
("n_bold", "coregister"), |
Has some fiddling with Dockerfiles so I can try to run tests locally, but I haven't gotten it to work yet. Been a while since I developed inside containers.