8000 rf: Allow callers to pass a pre-computed epi2anat transform for SyN by effigies · Pull Request #485 · nipreps/sdcflows · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rf: Allow callers to pass a pre-computed epi2anat transform for SyN #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

effigies
Copy link
Member

Has some fiddling with Dockerfiles so I can try to run tests locally, but I haven't gotten it to work yet. Been a while since I developed inside containers.

Copy link
codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 2.55%. Comparing base (f3b32fc) to head (6d0b2e2).

Files with missing lines Patch % Lines
sdcflows/workflows/fit/syn.py 0.00% 18 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f3b32fc) and HEAD (6d0b2e2). Click for more details.

HEAD has 22 uploads less than BASE
Flag BASE (f3b32fc) HEAD (6d0b2e2)
33 11
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #485       +/-   ##
==========================================
- Coverage   84.32%   2.55%   -81.78%     
==========================================
  Files          30      30               
  Lines        2846    2854        +8     
  Branches      367     294       -73     
==========================================
- Hits         2400      73     -2327     
- Misses        376    2780     +2404     
+ Partials       70       1       -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies marked this pull request as draft March 26, 2025 20:52
Dockerfile Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to push these updates independently of the rest of the PR?

else:
workflow.connect([
(inputnode, transform_list, [("epi2anat_xfm", "in1")]),
])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
])
]) # fmt:skip

@@ -44,12 +46,11 @@
@pytest.mark.parametrize(
("n_bold", "coregister", "sd_prior"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("n_bold", "coregister", "sd_prior"),
("n_bold", "coregister"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0