clean: skip directories that dont exist #340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
Try to make it easier to maintain when the list of paths to check grows. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
|
Added a couple commits for a couple different ideas for adding some notice about skipped paths and / or making maintenance easier if the directories to check changes ever. |
Also apply the protection logic to the `all` command. Noticed it suffered the same issue. Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
khaneliman
added a commit
to khaneliman/khanelinix
that referenced
this pull request
Jul 1, 2025
With nix-community/home-manager#7341 merged, adding patch for nix-community/nh#340 until that gets merged so my clean agent runs properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing nix-community/home-manager#7341 I noticed the launchd agent reporting a failure, even though I can run it in the terminal. I noticed that, even in terminal, it throws an error on a path that doesn't exist but continues to clean up the paths that do. Just adding some directory exists checks before attempting to clean paths for a cleaner output.
I guess a design question would be, do we need to alert that we're skipping a path?