Fix issue where ManageDSAit control sent #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thanks @elan100cs! |
DBarney
pushed a commit
to DBarney/ldap
that referenced
this pull request
Sep 13, 2023
* Fix whitespace control value * Add strings package
shipperizer
pushed a commit
to shipperizer/ldap
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ManageDSAit control was sent, the Control Value are expected to be empty.
Instead what happen previously, a whitespace was sent as a result of the encoding process. This causes the backend ldap to complain and returns an error.
This change ensures that no whitespace are sent in the control value.