8000 Refactor DeciderModule by Milena-Czierlinski · Pull Request #567 · nmshd/runtime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor DeciderModule #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 2 commits into from
May 22, 2025
Merged

Refactor DeciderModule #567

merged 2 commits into from
May 22, 2025

Conversation

Milena-Czierlinski
Copy link
Contributor
@Milena-Czierlinski Milena-Czierlinski commented May 21, 2025 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@Milena-Czierlinski Milena-Czierlinski added the refactoring Refactoring of code label May 21, 2025
@codecov Codecov
Copy link
codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/runtime/src/modules/DeciderModule.ts 66.66% 9 Missing ⚠️
Files with missing lines Coverage Δ
packages/runtime/src/modules/DeciderModule.ts 80.26% <66.66%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jkoenig134
jkoenig134 reviewed May 22, 2025
View reviewed changes
@Milena-Czierlinski Milena-Czierlinski changed the title Extract accept and reject to separate functions in DeciderModule Refactor DeciderModule May 22, 2025
@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review May 22, 2025 07:56
@Milena-Czierlinski Milena-Czierlinski merged commit c0d2431 into main May 22, 2025
15 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the refactor-decider-module branch May 22, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees
No one assigned
Labels
refactoring Refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Milena-Czierlinski @jkoenig134
0