Crucible roles linting #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following to chrony.conf - Set a listening address for the server. - set a default listen address of 127.0.0.1 - Cleaned up chrony.conf file - Added an enable_logging flag to the role defaults (off)
This being missing means that assisted installer will attempt to pull by tag this breaks the redirect policy in patch-search-registries which will break disconnected installs
…deployed Option of get_all_release_version which will populate all release versions for multiversion deployments The version deployed are configured by ocp_release_versions_map which can be manually configured to deploy a specific set of versions if required
This makes it so that create and destroy of virtual machines is possible without effecting virtual machines of other clusters on the same host
Move prompt jinja template into its own file
Using a ternary caused both sides to be evaluated so we switched to a jinja based if which removed that issue and is easier to read.
Also add tests for that check
This will allow people who are doing bare metal only deployments to remove the vm_hosts group
This stops any other roles which would use setup_selfsigned_cert from overwriting the value
Now that vm_host is no longer a guaranteed use inventory_hostname to look up the cert values
This will allow the cert to be setup correctly in the even that the ansible_fqdn returns and erroneous FQDN
34fc097 to
d6c5bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.