fix: #760 Do not apply old style settings when Style is blank #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where Style remained blank when config.yaml was missing. This occurred because old settings were applied even when Style was blank, leading to a blank configuration when config.yaml was absent. With this fix, old style settings will not be applied if Style is blank.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
May 10, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [noborus/ov](https://github.com/noborus/ov) | minor | `v0.39.0` -> `v0.40.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>noborus/ov (noborus/ov)</summary> ### [`v0.40.1`](https://github.com/noborus/ov/releases/tag/v0.40.1) [Compare Source](noborus/ov@v0.40.0...v0.40.1) #### What's Changed - fix: [#​760](noborus/ov#760) Do not apply old style settings when Style is blank by [@​noborus](https://github.com/noborus) in noborus/ov#761 **Full Changelog**: noborus/ov@v0.40.0...v0.40.1 ### [`v0.40.0`](https://github.com/noborus/ov/releases/tag/v0.40.0) [Compare Source](noborus/ov@v0.39.0...v0.40.0) Please use [v0.40.1](https://github.com/noborus/ov/releases/tag/v0.40.1) as there is a bug. #### What's Changed - Add styled terminal output with toggleable raw text option by [@​noborus](https://github.com/noborus) in noborus/ov#731. Resolves issue [#​684](noborus/ov#684) Thanks to [@​morenathan](https://github.com/morenathan) - Add `-m` as a short option for `--view-mode` by [@​noborus](https://github.com/noborus) in noborus/ov#734. Resolves issue [#​733](noborus/ov#733) Thanks to [@​Jaykul](https://github.com/Jaykul) - Add `--list-view-modes` option by [@​noborus](https://github.com/noborus) in noborus/ov#736 - make minStartX configurable with default value 0 by [@​noborus](https://github.com/noborus) in noborus/ov#742 This fix is related to issue [#​739](noborus/ov#739). Thanks to [@​hupfdule](https://github.com/hupfdule) - Change Style config to general/Style/ by [@​noborus](https://github.com/noborus) in noborus/ov#743 - Added clipboard via osc52 by [@​noborus](https://github.com/noborus) in noborus/ov#748 This resolves issue [#​747](noborus/ov#747) Thanks to [@​cstrahan](https://github.com/cstrahan) - Changed cbind url because it has moved to codeberg.org/tslocum/cbind by [@​noborus](https://github.com/noborus) in noborus/ov#758 This fix is related to pull request [#​757](noborus/ov#757). Thanks to [@​wreedb](https://github.com/wreedb) **Full Changelog**: noborus/ov@v0.39.0...v0.40.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xMS4yIiwidXBkYXRlZEluVmVyIjoiNDAuMTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where Style remained blank when config.yaml was missing. This occurred because old settings were applied even when Style was blank, leading to a blank configuration when config.yaml was absent.
With this fix, old style settings will not be applied if Style is blank.
fix #760