Support editing non-seekable files via read-only temporary file #782
+51
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Non-seekable files are now exported to a read-only temporary file for editing - Seekable files now trigger automatic reload after editing This is a continuation of the implementation of issue #780.
- Resolved an issue where the application could freeze if the editor command failed to execute - Now properly handles command execution errors and displays an appropriate message
- Changed the timing to delete the temporary file: now it is removed after resuming the screen - Prevents issues that could occur if the file is deleted before resume
noborus
commented
May 26, 2025
| } | ||
| // Reload the document after editing. | ||
| if isTemp { | ||
| os.Remove(fileName) // Clean up the temporary file. |
There was a problem hiding this comment.
If anyone has any objections to deleting temporary files please comment.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for editing non-seekable files by exporting them to a read-only temporary file and automatically reloading seekable files after editing.
- Changed the default editor command from "vi" to "vim +%d %f" to include placeholders.
- Introduced conditional handling to create a temporary file for non-seekable documents and trigger a reload for seekable ones.
- Updated the editor execution setup, including a change in the standard input assignment.
Comments suppressed due to low confidence (1)
oviewer/edit.go:64
- Assigning os.Stdout to c.Stdin may prevent the editor from receiving user input correctly. Consider reverting this to os.Stdin to ensure interactive editing works as expected.
c.Stdin = os.Stdout
|
It's working as intended. |
Thank you for trying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the implementation of issue #780.