feat: Add option to toggle status line visibility #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented the ability to hide/show the status line via command-line option, config, and runtime shortcut key - When the status line is hidden, it will only be shown in input mode or when a message is present Implemented #426
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new feature to toggle the status line visibility via configuration, command-line options, and a runtime shortcut.
- Adds logic to compute and update the status line height based on runtime and message conditions.
- Introduces tests for toggling behavior and integrates key bindings, configuration updates, and drawing logic modifications.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| oviewer/status_line.go | Updates the status line drawing logic to conditionally hide/show based on status height. |
| oviewer/prepare_draw_test.go | Adds tests to verify the correct determination of the status line based on various states. |
| oviewer/prepare_draw.go | Updates the screen preparation logic to compute status line height using status settings. |
| oviewer/oviewer.go | Introduces the status line field in the main configuration struct and binds it. |
| oviewer/keybind.go | Adds a new key binding for toggling the status line. |
| oviewer/draw.go | Modifies the drawing loop to account for the status line height. |
| oviewer/config.go | Adds configuration support for enabling/disabling the status line. |
| oviewer/action_test.go | Implements tests for the new status line toggle action. |
| oviewer/action.go | Implements the toggleStatusLine action method. |
| main.go | Registers and binds the CLI flag for the status line setting. |
Comments suppressed due to low confidence (4)
oviewer/status_line.go:17
- The variable 'statutsLineHeight' appears misspelled; consider renaming it to 'statusLineHeight' for clarity.
if root.scr.statutsLineHeight == 0 {
oviewer/prepare_draw.go:28
- The field 'statutsLineHeight' is misspelled; renaming it to 'statusLineHeight' would improve readability and consistency.
root.Doc.statusPos = root.scr.vHeight - root.scr.statutsLineHeight
oviewer/oviewer.go:111
- The field 'statutsLineHeight' seems misspelled; please rename it to 'statusLineHeight' to match common naming conventions.
statutsLineHeight int
oviewer/draw.go:59
- The variable 'statutsLineHeight' appears misspelled; update it to 'statusLineHeight' to ensure consistency with related code.
for y := m.headerHeight; y < root.scr.vHeight-root.scr.statutsLineHeight; y++ {
|
Thank you for your work. Just tested it and it's great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be ap
2AFF
plied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #426