8000 CacheRevalidationHandler: add missing header to comment by alxndrsn · Pull Request #4111 · nodejs/undici · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CacheRevalidationHandler: add missing header to comment #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

alxndrsn
Copy link
Contributor
@alxndrsn alxndrsn commented Mar 21, 2025

Include if-not-modified as a potential header which can tell the origin we want to revlidate.

This relates to...

Rationale

The current comment implies that if-modified-since is the only header relevant to revalidation.

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Include if-not-modified as a potential header which can tell the origin we want to revlidate.
@alxndrsn alxndrsn changed the title CacheRevalidationHandler: extend comment CacheRevalidationHandler: add missing header to comment Mar 21, 2025
Copy link
Member
@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95 metcoder95 merged commit 2df904f into nodejs:main Mar 21, 2025
28 of 31 checks passed
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0