8000 Options class with input validation by apozharski · Pull Request #40 · nosnoc/nosnoc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Options class with input validation #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 19, 2023
Merged

Options class with input validation #40

merged 19 commits into from
Apr 19, 2023

Conversation

apozharski
Copy link
Member
@apozharski apozharski commented Apr 13, 2023 •
edited
Loading
  • Convert settings structure to options class with input validation and consolidate the refine_settings duplication.
  • convert pss_mode to dcs_mode
  • add IRKSchemes enum
  • fixed some esoteric bugs with irk_representation = differential
  • Bump minimum matlab version to R2020b in order to use all property validation functions

apozharski added 16 commits April 12, 2023 19:57
@apozharski apozharski changed the title [WIP] Options class with input validation Options class with input validation Apr 13, 2023
@apozharski apozharski requested a review from nurkanovic April 13, 2023 14:17
nurkanovic
nurkanovic approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member
@nurkanovic nurkanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Anton, thanks!
Can be merged.

@nurkanovic nurkanovic merged commit d314a12 into main Apr 19, 2023
@nurkanovic nurkanovic deleted the options-class branch April 19, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurkanovic nurkanovic nurkanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apozharski @nurkanovic
0