-
Notifications
You must be signed in to change notification settings - Fork 673
remove bloat that no one cares about from nip11 #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
At least keep privacy policy and tos. @dskvr might have opinions. |
i've seen people using payment_required and auth_required. No idea about the other fields |
Also, flotilla uses auth_required, payment_required, and min_pow_difficulty (just to display to users). |
Amethyst shows all of them to the user. And I believe all clients MUST do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK
I really wish none of these limits existed. They just make clients more complex by requiring clients to go around them and break one thing down into multiple parts. You only take 20 filters for a sub with 40? Ok, I will do 2 subs of 20 filters each. In the end, the relay ends up doing more work than before. It's just more work for everybody. |
What if the relay limits the number of connections by IP? You will use a VPN and use a different IP for each connection? (This is an honest question on how this ends.) |
I also wish none of these limits existed for the reasons you mention, but at least the default limit of events to be returned is necessary otherwise clients would inadvertently end up downloading a million events when they just wanted to display the first 10 just because they forgot to specify the "limit". Vibecoders won't even notice it ever. Limits in the number of open requests are also useful sometimes to let the vibecoder know that they are leaking a ton of open subscriptions without even realizing. |
Let them load the 10000 or even millions of events. They will notice the mistake in the first time they test. If we hide it, we just make things worse. |
11.md
Outdated
"auth_required": true, | ||
"payment_required": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actively used.
11.md
Outdated
### Pay-to-Relay | ||
|
||
Relays that require payments may want to expose their fee schedules. | ||
|
||
```jsonc | ||
{ | ||
"payments_url": "https://my-relay/payments", | ||
"fees": { | ||
"admission": [{ "amount": 1000000, "unit": "msats" }], | ||
"subscription": [{ "amount": 5000000, "unit": "msats", "period": 2592000 }], | ||
"publication": [{ "kinds": [4], "amount": 100, "unit": "msats" }], | ||
}, | ||
// other fields... | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damus uses this to display payment information and other clients do too, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actively used.
11.md
Outdated
@@ -100,270 +86,18 @@ are rejected or fail immediately. | |||
```jsonc | |||
{ | |||
"limitation": { | |||
"max_message_length": 16384, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a web environment I do not think the WS bytes limit is not accessible. So this is useful.
I agree with this. For NFDB I implemented a ratelimit policy based off of IP address, and based off of how much work is being done (how many events read from DB, and memory size of subscriptions) instead. |
I am already using an Embed Tor to create multiple exit node IPs that reach out to Relays. |
Agree.
|
Please take a look at this new commit. Mostly I've removed the "content" guidelines this time. I've kept the restriction numbers and the payments stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The merging of the ToS/PP is a good idea, as the link should go to a page that contains easy-to-read sections, and the users can see separate legal versions if they wish easily.
Is anyone using any of these things?