Restore env and expandenv. #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree here and think we should add them back. In the case of Helm, these methods have been removed because of the security implications of running a 3rd party chart in which the chart author could have access to Tiller's environment. And since we already parse environment variables, and have since release 1.0.0 of gucci, I think it's fine to add these sprig methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the ability to reference environment variables with the
{{ .VARNAME }}syntax is useful, it throws whenVARNAMEis not defined.It is sometimes useful to have the shell behaviour of an undefined environment variable expanding to the empty string.
For instance, when
FOOis undefined, templateIt is set to "{{ .FOO }}"throwsmap has no entry for key "FOO"when it might be desirable for it to expand toIt is set to ""instead.With
env, the above is possible.It is set to "{{ env "FOO" }}"works as expected.#14 added Sprig functions, which is nice, and removed
envandexpandenvwith the justification that "Helm doesn't have them" but I think they are useful enough to keep.