8000 remove support for <py36 by dbarrosop · Pull Request #174 · nornir-automation/nornir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove support for <py36 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2018
Merged

remove support for <py36 #174

merged 4 commits into from
Jul 17, 2018

Conversation

dbarrosop
Copy link
Contributor
@dbarrosop dbarrosop commented Jul 9, 2018 •
edited
Loading

TODO: Update installation guide

@coveralls
Copy link
coveralls commented Jul 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 741

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 711: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@ktbyers
Copy link
Collaborator
ktbyers commented Jul 9, 2018

+1 except for the Python3.7 not existing on Travis.

@dbarrosop
Copy link
Contributor Author

Ok, will fix that. I want to first merge as many PRs as possible and make a 1.1 release before removing the support though.

@dbarrosop dbarrosop changed the title remove support for <py36 [DO NOT MERGE] remove support for <py36 Jul 10, 2018
@ogenstad
Copy link
Collaborator

Might be going back and forth with this, but perhaps we should leave 3.4 and 3.5 until we actually start using a 3.6 only feature.

@dbarrosop
Copy link
Contributor Author

I think we should do this exercise once to avoid alienating users twice. I am fine if we decide to postpone this a bit but I don't think we should do this twice.

@ktbyers
Copy link
Collaborator
ktbyers commented Jul 12, 2018
8000

I suspect PY3.4 is probably pretty close to EOL (given that we now have 3.5, 3.6, and 3.7)...though definite assumption on my part and I couldn't find any exact date on this.

My preference is 3.6 and greater.

@dbarrosop
Copy link
Contributor Author

Yeah, let's stop messing around with this and go directly with py3.6.

@dbarrosop dbarrosop changed the base branch from develop to 2.0 July 17, 2018 09:00
@dbarrosop dbarrosop changed the title [DO NOT MERGE] remove support for <py36 remove support for <py36 Jul 17, 2018
@dbarrosop dbarrosop merged commit aec37d2 into 2.0 Jul 17, 2018
@dbarrosop dbarrosop deleted the py36only branch July 17, 2018 09:01
omershtivi pushed a commit to omershtivi/nornir that referenced this pull request Dec 6, 2018
@dbarrosop @omershtivi1
emove support for <py36 (nornir-automation#174)
0342232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbarrosop @coveralls @ktbyers @ogenstad
0