Conceal highlighting group support
#261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in GH-149, GH-207 and GH-211 with LaTeX and Pandoc being used by the reporters. PR GH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> GH-256
svengreb
approved these changes
May 28, 2021
This was referenced May 28, 2021
Conceal highlighting group support
crispgm
pushed a commit
to crispgm/nord-vim
that referenced
this pull request
Jun 10, 2021
The `Conceal` group was not supported which could have led to rendering problems for (Unicode) characters that require special encoding like the ones from the Greek alphabet [1] that are often used in LaTeX [3] or Pandoc [4] documents. These characters were highlighted with the default background color which makes them kind of unreadable with the theme foreground color. See `:help conceal` and `:help concealcursor` for more details about concealing in Vim. To fix the problem, the `Conceal` group has been added with its background color set to `NONE` for GUI and terminal mode to either use the terminal default background color or let loaded scripts apply custom styles based on the current runtime context. The problem has been reported in nordthemeGH-149, nordthemeGH-207 and nordthemeGH-211 with LaTeX and Pandoc being used by the reporters. PR nordthemeGH-220 adds support for vim-pandoc/vim-pandoc-syntax [5] specific highlighting groups and can be merged after adding basic support for `Conceal`. [1]: https://en.wikipedia.org/wiki/Greek_alphabet [2]: https://www.overleaf.com/learn/latex/mathematical_expressions [3]: https://www.latex-project.org [4]: https://pandoc.org [5]: https://github.com/vim-pandoc/vim-pandoc-syntax Co-authored-by: Sven Greb <development@svengreb.de> Closes nordthemeGH-256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #149
Resolves #207
Resolves #211
Resolves #256
Closes #228
Ensure the following configurations are set to get the correct rendering for such elements:
Before
After