10000 ENH: Add select_intersection kwarg to transformers by richford · Pull Request #61 · nrdg/groupyr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ENH: Add select_intersection kwarg to transformers #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2021
Merged

ENH: Add select_intersection kwarg to transformers #61

merged 4 commits into from
Jul 7, 2021

Conversation

richford
Copy link
Member
@richford richford commented Jul 6, 2021

This PR adds a select_intersection parameter to GroupShuffler, GroupExtractor, and GroupRemover. Previously, if you passed a sequence of group labels to any of these transformers, it would return the union of group labels. Now, if you pass select_intersection=True, it will return the intersection of the labels.

Resolves #60

@richford richford added the enhancement New feature or request label Jul 6, 2021
@richford richford requested a review from arokem July 6, 2021 22:55
@coveralls
Copy link
coveralls commented Jul 6, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 96.271% when pulling e328e9d on enh/group-extractor-union-or-intersection into 36e0441 on main.

arokem
arokem approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member
@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of typos, but otherwise, ready to merge.

richford and others added 3 commits July 6, 2021 21:07
@richford @arokem
Update groupyr/transform.py
f60a753 
Co-authored-by: Ariel Rokem <arokem@gmail.com>
@richford @arokem
Update groupyr/transform.py
2447629 
Co-authored-by: Ariel Rokem <arokem@gmail.com>
@richford
Fix typo in transform
e328e9d
@richford richford merged commit 0d5c17c into main Jul 7, 2021
@richford richford deleted the enh/group-extractor-union-or-intersection branch July 7, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arokem arokem arokem approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow transformers to return the intersection of groups
3 participants
@richford @coveralls @arokem
0