fix(core): fixed package version matching when generating pnpm lockfile #30373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Bump |
Comment on lines
+607
to
+609
| const exactMatchedNode = nodes[`${nodeKeyPrefix}}@${packageJsonVersion}`] | ||
| || nodes[`${nodeKeyPrefix}}@${packageJsonVersion.replace(/^~/, '')}`] | ||
| || nodes[nodeKeyPrefix]; |
There was a problem hiding this comment.
There are syntax errors in the template literals - extra closing curly braces appear in both lines. Please correct:
// From:
nodes[`${nodeKeyPrefix}}@${packageJsonVersion}`]
nodes[`${nodeKeyPrefix}}@${packageJsonVersion.replace(/^~/, '')}`]
// To:
nodes[`${nodeKeyPrefix}@${packageJsonVersion}`]
nodes[`${nodeKeyPrefix}@${packageJsonVersion.replace(/^~/, '')}`]These extra braces would cause incorrect key lookups in the nodes object.
Suggested change
| const exactMatchedNode = nodes[`${nodeKeyPrefix}}@${packageJsonVersion}`] | |
| || nodes[`${nodeKeyPrefix}}@${packageJsonVersion.replace(/^~/, '')}`] | |
| || nodes[nodeKeyPrefix]; | |
| const exactMatchedNode = nodes[`${nodeKeyPrefix}@${packageJsonVersion}`] | |
| || nodes[`${nodeKeyPrefix}@${packageJsonVersion.replace(/^~/, '')}`] | |
| || nodes[nodeKeyPrefix]; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| return nodes[nodeKey]; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The function is missing a return value for the case when no compatible node is found. This could result in undefined being returned, potentially causing errors elsewhere. Consider adding a default return value or explicit error handling at the end of the function.
Suggested change
| } | |
| return null; // No compatible node found | |
| } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When building an app using pnpm, webpack and NxAppWebpackPlugin with
generatePackageJson: true, the error is thrown. This happens during pruned lockfile generation:Expected Behavior
No error should be thrown.
Related Issue(s)
Fixes #28627