8000 Sign-in broken via both slack and google · Issue #1116 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sign-in broken via both slack and google #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samitks opened this issue Dec 20, 2019 · 6 comments · Fixed by #1119
Closed

Sign-in broken via both slack and google #1116

samitks opened this issue Dec 20, 2019 · 6 comments · Fixed by #1119
Assignees
@tommoor
Labels
bug

Comments

@samitks
Copy link
samitks commented Dec 20, 2019

I was trying to set up outline and found that the sign-in via google and slack is now broken. You will be able to to login first time. However, once you logout and login back, it gives an error:

"Authentication failed - we were unable to sign you in at this time."

I further enabled detailed logs and found the below error in the logs:

EXCEPTION WHEN unique_violation THEN GET STACKED DIAGNOSTICS sequelize_caught_exception = PG_EXCEPTION_DETAIL;

Further, I checked out and found that it was trying to insert a row in the 'users' table and getting failed because of duplicate key error for the 'email' field.

This can also be produced in the development mode using docker-compose.

I updated the HEAD to 5731ff3 (Dec 7) and everything works fine now.

Kindly check and let me know if this is a bug or something is missing from my side in the setup.
@vizcay
Copy link
vizcay commented Dec 22, 2019 •
edited
Loading

@compengsamit same issue here, checked out tag v0.38.0 while running locally on production mode with yarn start.

I was able to setup Slack OAuth and login, create wiki pages etc. Everything seemed to work fine.. then after a log out and log in.. totally stuck with:

Authentication failed - we were unable to sign you in at this time. Please try again.

@vizcay
Copy link
vizcay commented Dec 22, 2019

More info: I've just nuked the db, checked out v0.37.0 and setup everything again. The bug wasn't present there so it must be introduced on v0.38.0.

@filipenatanael
Copy link

I got the same issues yesterday! I tried several approaches but it didn't work. I noticed the cookie were passed as undefined then I thought, it might be something related to my insecure subdomain. I tried to add a nginx reverse proxy to serve instance but I didn't get success either. Then I decided to downgrade outline version to v0.37.0 and everything its working now.

@tommoor
Copy link
Member
tommoor commented Dec 23, 2019 •
edited
Loading

Looking into this – do you know if you sent out any invites from within the app? I have some leads as to what the issue might be – it certainly isn't affecting all signins.

@tommoor tommoor self-assigned this Dec 23, 2019
@tommoor tommoor added bug more information needed This issue will be automatically closed unless more details are provided labels Dec 23, 2019
@samitks
Copy link
Author
samitks commented Dec 23, 2019

@tommoor I did a fresh install and did not send out 8000 any invites or created any collection. Just a fresh install, sign-in and sign-out and then trying to sign in again doesn't work.

@no-response no-response bot removed the more information needed This issue will be automatically closed unless more details are provided label Dec 23, 2019
tommoor added a commit that referenced this issue Dec 23, 2019
@tommoor
Initial fix for #1116
cc81e6c
@tommoor tommoor mentioned this issue Dec 23, 2019
Merged
tommoor added a commit that referenced this issue Dec 23, 2019
@tommoor
fix: User records not written correctly on signin (#1119)
98dda56 
* Initial fix for #1116

* clarify logic
@tommoor
Copy link
Member
tommoor commented Dec 23, 2019 •
edited
Loading

This is now addressed on master, thanks for the heads up, this was honestly quite a bad bug – point release published as v0.38.1.

If you have existing users that were created they'll need to be wiped from the DB, the easiest way to do this is to just make the email field a blank string, at which point they'll be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommoor tommoor

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: User records not written correctly on signin outline/outline
4 participants
@tommoor @vizcay @filipenatanael @samitks
0