feat: authenticationProviders API endpoints #1962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
commented
Mar 25, 2021
| @@ -0,0 +1,52 @@ | |||
| // @flow | |||
|
|
||
| const log = debug("server"); | ||
| const app = new Koa(); | ||
| const router = new Router(); | ||
|
|
||
| router.use(passport.initialize()); | ||
|
|
||
| // dynamically load available authentication providers | ||
| requireDirectory(__dirname).forEach(([{ default: provider, config }]) => { |
There was a problem hiding this comment.
There were multiple places this require loop happened, now it happens once in ./providers and is imported elsewhere
| @@ -0,0 +1,31 @@ | |||
| // @flow | |||
There was a problem hiding this comment.
🍖 Policies for authentication providers
guard against disabling all auth methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the foundation for #1945, allowing the listing and disabling of individual authentication providers.
/auth/providersfolder (view without whitespace changes)authenticationProviders.listendpoint to list auth providers with team statusauthenticationProviders.infoendpointauthenticationProviders.updateendpoint to enable and disable