fix: Use team name on link metadata if public branding enabled #9273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the link metadata logic to use the team name as the title when public branding is enabled.
- Conditionally assigns the team name to the title if public branding is enabled.
- Adjusts the arguments passed to the renderApp function in the index route.
Comment on lines
173
to
+177
| return renderApp(ctx, next, { | ||
| title: | ||
| team?.getPreference(TeamPreference.PublicBranding) && team.name | ||
| ? team.name | ||
| : undefined, |
There was a problem hiding this comment.
[nitpick] Consider extracting the conditional assignment for title into a separate variable to improve clarity and simplify the renderApp call.
Suggested change
| return renderApp(ctx, next, { | |
| title: | |
| team?.getPreference(TeamPreference.PublicBranding) && team.name | |
| ? team.name | |
| : undefined, | |
| const title = | |
| team?.getPreference(TeamPreference.PublicBranding) && team.name | |
| ? team.name | |
| : undefined; | |
| return renderApp(ctx, next, { | |
| title, |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9269