feat(api): delete workflow run on branch delete #4177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
golangcibot
reviewed
Apr 10, 2019
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
fsamin
reviewed
Apr 11, 2019
sguiheux
requested changes
Apr 15, 2019
| return err | ||
| } | ||
|
|
||
| if err := workflow.MarkWorkflowRunsAsDelete(api.mustDB(), wfIDs); err != nil { |
There was a problem hiding this comment.
Do we have to stop them all?
There was a problem hiding this comment.
No, with future commit it will be deleted 24h after, so it will be stopped
richardlt
approved these changes
Apr 15, 2019
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
golangcibot
reviewed
Apr 15, 2019
engine/hooks/webhook.go
Outdated
| @@ -49,6 +52,9 @@ func executeRepositoryWebHook(t *sdk.TaskExecution) ([]sdk.WorkflowNodeRunHookEv | |||
| return nil, sdk.WrapError(err, "unable ro read github request: %s", string(t.WebHook.RequestBody)) | |||
| } | |||
| if pushEvent.Deleted { | |||
| branch := strings.TrimPrefix(pushEvent.Ref, "refs/heads/") | |||
| s.enqueueBranchDeletion(t.UUID, projectKey, workflowName, branch) | |||
There was a problem hiding this comment.
Error return value of s.enqueueBranchDeletion is not checked (from errcheck)
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
|
missing some doc about vcs event on https://ovh.github.io/cds/docs/integrations/bitbucket/ , https://ovh.github.io/cds/docs/integrations/github/, and https://ovh.github.io/cds/docs/integrations/gitlab/ |
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
yesnault
requested changes
Apr 29, 2019
Co-Authored-By: bnjjj <benjamin.coenen@hotmail.com>
yesnault
approved these changes
Apr 29, 2019
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
sguiheux
approved these changes
May 13, 2019
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
fsamin
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com
close delete workflow run related to deleted branches #2517
@ovh/cds