8000 feat(engine): add aws s3 object store by reynn · Pull Request #4195 · ovh/cds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(engine): add aws s3 object store #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2019
Merged

feat(engine): add aws s3 object store #4195

merged 1 commit into from
Apr 22, 2019

Conversation

reynn
Copy link
Contributor
@reynn reynn commented Apr 16, 2019

includes some refactoring to swift store

  1. Description: Add AWS S3 as an option for ObjectStore

@ovh/cds

richardlt
richardlt requested changes Apr 17, 2019
View reviewed changes
@yesnault
Copy link
Member

Thank a lot, this is awesome :)

About vendor directory, we'll keep it for now.
Can you take in account the suggested change ? Then, we will merge your Pull Request on a development branch for testing, updating vendor and add some documentation about this new integration. We will merge the PR (without squashing of course) after that, for the release 0.40.x (0.39.0 is coming today)

golangcibot
golangcibot 8000 reviewed Apr 19, 2019
View reviewed changes
feat(engine): add aws s3 object store
cd8fbd6 
includes some refactoring to swift store
@yesnault yesnault changed the base branch from master to reynn-master-s3 April 22, 2019 14:35
@yesnault yesnault merged commit 39f03bb into ovh:reynn-master-s3 Apr 22, 2019
@yesnault
Copy link
Member

@reynn it's now on #4207, with vendor updated and doc (incoming). Thank you very much again for this PR.

yesnault added a commit that referenced this pull request Apr 22, 2019
@yesnault
chore: update vendor
fe29982 
ref #4195

Signed-off-by: Yvonnick Esnault <yvonnick@esnau.lt>
yesnault pushed a commit that referenced this pull request Apr 29, 2019
@yesnault
feat(engine): add aws s3 object store (#4195)
5faec5f
yesnault added a commit that referenced this pull request Apr 29, 2019
@yesnault
chore: update vendor
dd4c4b3 
ref #4195

Signed-off-by: Yvonnick Esnault <yvonnick@esnau.lt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@richardlt richardlt richardlt approved these changes

@bnjjj bnjjj Awaiting requested review from bnjjj

@fsamin fsamin Awaiting requested review from fsamin

@sguiheux sguiheux Awaiting requested review from sguiheux

@yesnault yesnault Awaiting requested review from yesnault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reynn @yesnault @richardlt @golangcibot
0