8000 Workflow template by richardlt · Pull Request #3387 · ovh/cds · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Workflow template #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 87 commits into from
Dec 3, 2018
Merged

Workflow template #3387

merged 87 commits into from
Dec 3, 2018

Conversation

richardlt
Copy link
Member
@richardlt richardlt commented Oct 2, 2018 •
edited by yesnault
Loading
  1. Description
  2. Related issues
    close feat (api): workflow templates #742
  3. About tests
  4. Mentions

@ovh/cds

@richardlt richardlt changed the title Wip workflow template WIP workflow template Oct 2, 2018
golangcibot
golangcibot reviewed Oct 2, 2018
View reviewed changes
sguiheux
sguiheux requested changes Oct 3, 2018
View reviewed changes
golangcibot
golangcibot reviewed Oct 4, 2018
View reviewed changes
@richardlt richardlt force-pushed the feat-workflow-templates branch 2 times, most recently from 5bcf1de to 3a0d5b3 Compare October 4, 2018 16:05
bnjjj
bnjjj suggested changes Oct 5, 2018
View reviewed changes
golangcibot
golangcibot reviewed Oct 5, 2018
View reviewed changes
@richardlt richardlt force-pushed the feat-workflow-templates branch from e0d49a4 to 76160fb Compare October 8, 2018 14:30
@ovh ovh deleted a comment from ovh-cds Oct 10, 2018
@richardlt richardlt force-pushed the feat-workflow-templates branch from 06c7334 to 5b38f37 Compare October 10, 2018 16:02
bnjjj
bnjjj suggested changes Oct 15, 2018
View reviewed changes
@ovh ovh deleted a comment from ovh-cds Oct 15, 2018
@ovh ovh deleted a comment from ovh-cds Oct 15, 2018
@richardlt richardlt force-pushed the feat-workflow-templates branch from f95ef33 to f00b659 Compare October 15, 2018 15:50
bnjjj
bnjjj suggested changes Oct 17, 2018
View reviewed changes
@richardlt richardlt force-pushed the feat-workflow-templates branch from f909846 to 0f63c95 Compare October 17, 2018 14:48
@ovh ovh deleted a comment from ovh-cds Oct 17, 2018
@ovh ovh deleted a comment from ovh-cds Oct 17, 2018
@ovh ovh deleted a comment from ovh-cds Oct 19, 2018
@richardlt richardlt force-pushed the feat-workflow-templates branch 2 times, most recently from ee15569 to 8ba0b21 Compare October 24, 2018 21:11
@ovh ovh deleted a comment from ovh-cds Oct 25, 2018
@ovh ovh deleted a comment from ovh-cds Oct 25, 2018
@ovh ovh deleted a comment from ovh-cds Oct 25, 2018
@ovh ovh deleted a comment from ovh-cds Oct 25, 2018
golangcibot
golangcibot reviewed Nov 21, 2018
View reviewed changes
@richardlt richardlt force-pushed the feat-workflow-templates branch from 11f48f4 to 515a873 Compare November 22, 2018 13:57
bnjjj
bnjjj suggested changes Nov 30, 2018
View reviewed changes
fsamin
fsamin requested changes Dec 2, 2018
View reviewed changes
Copy link
Member
@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rebase (or merge) with master

engine/api/api.go
@@ -655,6 +656,9 @@ func (a *API) Serve(ctx context.Context) error {
sdk.GoRoutine(ctx, "workflow.ComputeAudit", func(ctx context.Context) {
workflow.ComputeAudit(ctx, a.DBConnectionFactory.GetDBMap)
})
sdk.GoRoutine(ctx, "workflowtemplate.ComputeAudit", func(ctx context.Context) {
workflowtemplate.ComputeAudit(ctx, a.DBConnectionFactory.GetDBMap)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to merge and do it :)

@bnjjj bnjjj merged commit 6518c9c into master Dec 3, 2018
@richardlt richardlt deleted the feat-workflow-templates branch December 3, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat (api): workflow templates
7 participants
@richardlt @ovh-cds @yesnault @fsamin @sguiheux @bnjjj @golangcibot
0