feat(ui): improve admin/services #3389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
This comment has been minimized.
This comment has been minimized.
richardlt
approved these changes
Oct 2, 2018
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
This comment has been minimized.
This comment has been minimized.
golangcibot
reviewed
Oct 2, 2018
engine/api/metrics.go
Outdated
| case "application/json": | ||
| return service.WriteJSON(w, mfs, http.StatusOK) | ||
| default: | ||
| w.Write(writer.Bytes()) |
There was a problem hiding this comment.
Error return value of w.Write is not checked
This comment has been minimized.
This comment has been minimized.
|
|
sguiheux
approved these changes
Oct 3, 2018
richardlt
approved these changes
Oct 3, 2018
richardlt
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yvonnick Esnault yvonnick.esnault@corp.ovh.com