8000 fix(pyproject): correct dependency version by pabloarosado · Pull Request #25 · owid/owid-datautils-py · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

fix(pyproject): correct dependency version #25

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

pabloarosado
Copy link
Collaborator

No description provided.

@pabloarosado pabloarosado requested a review from Marigold June 13, 2022 18:28
@codecov
Copy link
codecov bot commented Jun 13, 2022

Codecov Report

Merging #25 (f9fd7d7) into main (d729968) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files           7        7           
  Lines         394      394           
=======================================
  Hits          331      331           
  Misses         63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d729968...f9fd7d7. Read the comment docs.

@lucasrodes
Copy link
Member

Do we need to bump the version in a case like this one?

@pabloarosado
Copy link
Collaborator Author

Do we need to bump the version in a case like this one?

In general yes. But in this case, given that the previous release was unusable, my plan was to remove the previous release, merge this, and create another with the same tag. I think it's acceptable to do this at this early stage. But if you think we should keep the last release and just create a new one with another tag, I'm fine with that.

@pabloarosado pabloarosado requested a review from lucasrodes June 14, 2022 06:01
@pabloarosado pabloarosado merged commit 1b46530 into main Jun 14, 2022
@pabloarosado pabloarosado deleted the fix-dependency-version branch June 14, 2022 07:05
@lucasrodes
Copy link
Member

@pabloarosado I see your point. I think it is OK as we are in the early stage, as you mention. In the future, I'd say we just bump a version up (patch).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0