8000 Unconfigured OTR_HTTPPREFIX · Issue #399 · owntracks/recorder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unconfigured OTR_HTTPPREFIX #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpmens opened this issue Aug 12, 2022 · 2 comments
Closed

Unconfigured OTR_HTTPPREFIX #399

jpmens opened this issue Aug 12, 2022 · 2 comments

Comments

@jpmens
Copy link
Member
jpmens commented Aug 12, 2022

If OTR_HTTPPREFIX hasn't been configured (via defaults file or environment variable), the url saved in a tour view contains a literal (null):

"url": "(null)/view/ea83c5a1-e8e5-4c82-8c1b-175e784a959e"

which results in iOS attempting to use exactly that.

rabbit-9456

I don't think there's much we can do about it other than slightly "beautify" that null by returning a URL as

"url": "OTR_HTTPPREFIX/view/24c6bbb9-17bd-4b7e-b244-a2da77cb866f"

as an indication that something needs fixing server-side.
jpmens added a commit that referenced this issue Aug 12, 2022
@jpmens
add "OTR_HTTPPREFIX" (verbatim) to tour url if prefix unconfigured
5ecb2ae 
	addresses #399
@jpmens
Copy link
Member Author
jpmens commented Aug 12, 2022

I considered having Recorder exit with a fatal diagnostic, but we would break installations which are upgrading and are possibly not interested in Tours.

jpmens added a commit that referenced this issue Sep 29, 2022
@jpmens
2022-09-30 version 0.9.2
423ca2e 
- FIX: Remove accidental eval (#403)
- FIX: Various build fixes (#402)
- FIX: now compiles without MQTT (#401)
- FIX: read OTR_TOPICS from environment (overrides config); can be overriden by argv
- UPD: ocat -v shows compiled-in values, ot-recorder -V runtime ones
- FIX: add "OTR_HTTPPREFIX" (verbatim) to tour url if prefix unconfigured (#399)
- FIX: Duplicate log entries when running as daemon (#398)
- FIX: package build for raspbian
@jpmens
Copy link
Member Author
jpmens commented Nov 29, 2023

Closing as "slightly fixed".

@jpmens jpmens closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpmens
0